View Single Post
Old 05-04-2009, 11:36 PM  
ProG
Confirmed User
 
Join Date: Apr 2009
Posts: 1,319
Quote:
Originally Posted by GrouchyAdmin View Post
Again, that's the first time I've ever seen it in practice. Most people who expect to run multiplatform - or even on Windows, specifically, use the double-escaped-posix path and hardcode the \r\n into some of the print logic. I suppose 't' has it's place but as un-UTF as PHP can be, I'd really, really hate to allow for translation. That also explains the use of trim().

From a design standpoint - other than it since being asked for, I'm curious why you killed the pass/fail arrays - that was the only part of the code that I thought was salvageable.
Yes it's the first time I've used it as well. I do not typically code for Windows ;) As for the arrays, I really see no need to build two arrays then convert them to a string for writing, why not just build a string? Unless the arrays are used for something later, such as removing duplicates, why build them?
ProG is offline   Share thread on Digg Share thread on Twitter Share thread on Reddit Share thread on Facebook Reply With Quote