Help with a script please.

[Young]

Can anyone here take a look at a script for me? I had the script custom coded.....this might be the last time I outsource anything. Its a simple setup script to create tables in MySQL but doesn't seem to want to work.

Obviously I have changed the password, username, and database name for posting reason but I assure you that those are correctly set. The database already exists and this particular host limits me to one 10mb so that is why the setup file creates tables in an existing database.

setup.php
<?php
include 'sqlcnct.php';

// Select the database ; change the databasename with the one on your server if necessary.
$databasename = "removed";
$queryvar = mysql_select_db($databasename);


// Create news table
$maketab = "CREATE TABLE news ( title TEXT NOT NULL, content TEXT NOT NULL, added INT, expires INT, ntype TEXT, uid TEXT)";
// type is 0 if the news comes from external source, and the content is a link,
// and it is !=0 if the content is stored in the database
$queryvar = mysql_query($maketab);

// Create scroller table
$maketab = "CREATE TABLE scroller ( title TEXT NOT NULL, expires INT, uid TEXT)";
$queryvar = mysql_query($maketab);



// Create admin password table
$maketab = "CREATE TABLE admin ( usern TEXT NOT NULL, pass TEXT NOT NULL)";
$queryvar = mysql_query($maketab);

$defpass = crypt("removed",5);
$adminuser = "administrator";
// Insert the admin details
$maketab = "INSERT INTO admin VALUES('".$adminuser."','".$defpass."')";
$queryvar = mysql_query($maketab);

mysql_close($cnct);
echo "Tables successfully created! Please remember to delete this script from your server!";

?>


sqlcnct.php

<?php
$site = "removed";
$username = "removed";
$password = "removed";
$cnct=mysql_connect($site, $username, $password);

$databasename = "removed";
$queryvar = mysql_select_db($databasename);

?>


Thanks to anyone that can help me figure this out.

[Serge Litehead]

sql queries are good

what kind of error you getting?

[woj]

add in:
echo mysql_error()."<br>\n";

after each mysql_query() statement and paste the errors you are getting here...

[Juicy D. Links]